RE: OpenLedger trade engine bug or ..?

You are viewing a single comment's thread from:

OpenLedger trade engine bug or ..?

in bitshares •  8 years ago 

It would be helpful if you were more specific about your experiment. Any attempt to answer an unspecific question is only a shot in the dark.

In the example I cited, the actual trade price as calculated from paid/received amounts was off from the price of the offers on the market. The point here is that the paid/received amounts are calculated by applying the price of the market offer to the amount available for paying, and rounding the result. The rounding is necessary due to lack of precision in the target asset.

If that is not the problem that you verified in your experiment, again, please be more specific about what you perceive as the problem.

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!
Sort Order:  

My experience is the following. Names and prices changed, essence remains untouched.
I set a trade of Asset A at an "Ask" price of 1. Gradually it becomes the "Lowest Ask". At that moment the "Market History" section reports trades executed at "Ask" price of 1.5, which is not the "Lowest". So, it is easy to conclude that there is either a bug there, or someone was just inflating the price.

Now since you mentioned a rounding issue as known, never mind if irrelevant to my experience, I just underlined the fact that traders do not like trade engines which produce unexpected results.
That's all and thank you for your time.

Thanks. Without knowing the details (volume, assets involved) of the trade that happened at 1.5 it is impossible to tell if the rounding issue is the cause.

What I take from this is that we're talking about a UI issue here. Your point that this is unexpected and leads to confusion is absolutely valid. I do not see this as a bug in the market engine, though, but merely as a display problem.

Edit: added comment to github issue https://github.com/cryptonomex/graphene/issues/460#issuecomment-236355266