Cross-domain authentication is here! Big milestone reached!

amosbastian (72) · 6 years ago (edited)

Wow, what a great update! Making it so that users don't have to log in every time is definitely a huge improvement to the user experience. I'm very impressed with the amount of work that has been put into this update as well.

As for the code, it's mostly really great, but there are some things that I was wondering. In files such as sso_rest.js var is used a lot and the quality in general seems a bit lower than other parts of the codebase. For example, in authorize.ts the quality of the code is better, and const is used instead of var. I'm guessing that the former was taken from somewhere else, whereas the latter was written by yourself? If that's the case, then in my opinion you should mention this somewhere in the code at least, and maybe even in the post itself.

Either way, as I said before, this is a great update and it's obvious a lot of work went into it. For this reason, I will be picking it as a "staff pick", which means it will receive the highest reward possible for the development category. Looking forward to seeing more contributions from you guys in the future!

P.S. it says Jason instead of JSON, haha.

Need help? Chat with us on Discord.

engrave (64) · 6 years ago (edited)

Thank you, I really appreciate your feedback and decision!

In files such as sso_rest.js var is used a lot and the quality in general seems a bit lower than other parts of the codebase

The entire concept of SSO was adopted from this project, and some file was untouched, like sso_rest.js (four files if I remember correctly). It looks like a POC and some files could be written much better of course. I just wanted to focus on "bigger picture" of this update. But indeed, it's necessary to refactor those files. I will do it myself or maybe open an issue on Github and let to do it by one of the Utopian users? :)

I am aware of varied code quality. Engrave codebase is a one-man-job. I personally wrote every single line of code (except for some files like CSS for themes or those third-party solutions mentioned above) and gained a lot of experience doing that. There are still a lot of places that need to be refactored but I think I'm going in the right direction. Development is now much easier than previously. And I feel better as a backend than frontend developer as you can tell from both code quality and some imperfections of appearance. And I'm focused on missing features. There will be time to fine tune everything else :)

If that's the case, then in my opinion you should mention this somewhere in the code at least, and maybe even in the post itself.

I'm going to post more detailed technical articles as part of "Engineering" category of blog.engrave.website and there this information will be provided with all other details.

P.S. it says Jason instead of JSON, haha.

Wait, what? Where? There's nothing like that, and never was ;)

$0.03

4 votes

chrisrice (59) · 6 years ago

Is @engrave 100% open source?

$0.00

engrave (64) · 6 years ago

Yes

utopian-io (71) · 6 years ago

Thank you for your review, @amosbastian! Keep up the good work!

$0.00

felipejoys (71) · 6 years ago

I've mentioned your project, and I wish you a lot of success with it. By the way, how do I get ads to work in my engrave blog?
https://steemit.com/steem/@juanmolina/steem-s-value-vs-newbies-s-resources-credits-rc#@felipejoys/re-happyme-re-felipejoys-re-happyme-re-felipejoys-re-juanmolina-steem-s-value-vs-newbies-s-resources-credits-rc-20190222t075117412z

$0.62

engrave (64) · 6 years ago

Thanks for the mention! At this point, it is not possible to add custom scripts or adds to your blog but we are going to introduce "Theme manager" where you will be able to do that.

$0.00

felipejoys (71) · 6 years ago (edited)

IMO @engrave would be revolutionary if it allowed optional guest commenting through disqus, ads and blacklisting users so their comments don't show up on the blog (i.e. bots and spammers). This would allow for a clean blog anyone can access, further boosted by other sources of monetization.

$0.00

engrave (64) · 6 years ago

We're going to allow quest comments soon but without Disqus at all. Blacklisting users will be available soon as well, we're actually working at it right now :)

$0.00

edensgarden (6) · 6 years ago

Thanks for using @edensgarden!

$0.00

gniksivart (67) · 6 years ago

I have a question. I just set-up a blog using the site gniksivart.dblog.org and was wondering if my blog becomes profitable and I want to buy my own domain, is there anyways I can upgrade from gniksivart.dblog.org to something like gniksivart.com, or will I have to create a new Steem account and set-up the new blog under the new Steem account?

$0.22

4 votes

engrave (64) · 6 years ago

You will be able to move your domain to custom one without the need to create another account :)

$0.00

adetorrent (74) · 6 years ago

I'm trying to set up my blog. I'm trying to configure it now - need to point my custom domain to Engrave "servers". I didn't note down the servers when they first appeared, but now I can't seem to find what they are. Can you help me with the server names/addresses?

$0.11

engrave (64) · 6 years ago

Just point A and CNAME records to 139.162.185.235 :) In case of problems, visit our Discord.

PS. We're going to push a fix that will prevent situations like this :)

adetorrent (74) · 6 years ago

Thanks I'll try that now.

$0.00

rmach (68) · 6 years ago

cool. I only have one engrave blog but I can see how this is relevant. Very nice. Good work!

$0.04

engrave (64) · 6 years ago

Right now, every Engrave user have one blog... But previously if you wanted to interact with for example another blog, you had to log in into it specifically. Now, after this change - if you log in on your blog, you will be logged in on any other automatically.

It's working similar to Google authentication. You just need to login into your Gmail account, and you can use Calendar, Keep etc. Much, much more user-friendly :)

$0.00

luegenbaron (64) · 6 years ago

Awesome! :)

Excellent work!

Posted using Partiko Android

$0.00

chrisrice (59) · 6 years ago

Can you comment the link of your Engrave blog?

I want to visit it, to see what it looks like.

$0.00

rmach (68) · 6 years ago

Mine is karatespace.pt

I just started. It won't be a super dynamic blog. It will work as the official site for my karate club.
I'll post some articles I usually integrate in the club newsletter. Let's see how it goes :)

$0.00

engrave (64) · 6 years ago

Great! Will try to support you. Maybe some kind of custom template for your karate blog? :)

$0.00

chrisrice (59) · 6 years ago

Thanks @rmach 😊👍🏻

$0.00

engrave (64) · 6 years ago

Sure, you can visit it here: Engrave Blog. And here you can find much more blogs created by our users: https://engrave.website/explore

$0.00

chrisrice (59) · 6 years ago

The latest blog was created by me, for @emaferice, and under the domain:

Emafe.com

I clicked on the link on your site, listing Emafe.com as the latest blog, but it gave me a warning, saying that the site is not secure.

I clicked "Proceed anyways", and it sent me to a different blog, not Emafe.com.

Also, when I visit Emafe.com, it doesn't go to a Splash page for my wife's new @engrave blog, but goes to the Engrave.website homepage instead.

Is all of this normal? @engrave

$0.00

engrave (64) · 6 years ago

No, I will take a look at it right now :)

chrisrice (59) · 6 years ago

It looks like you fixed it @engrave thank you 😊👍🏻

$0.00

engrave (64) · 6 years ago

My pleasure!

$0.00

yabapmatt (69) · 6 years ago

Have you guys looked into supporting the Steem Keychain extension? This should allow people to automatically log in to any site without you having to store any tokens or without the user having to put their private keys into steem connect. Feel free to reach out if you need any more info about it.

$0.03

6 votes

engrave (64) · 6 years ago

I will look into it, but to be honest - I'm not a big fan of browsers extensions because of their update policy (it's possible to inject vulnerability just by an update without even a notice). But it sure might be interesting for some users so I will research this. Thanks!

$0.00

yabapmatt (69) · 6 years ago

Well the same could be said for steemconnect, but with the browser extension there's at least the option to download the code and run it locally, or use the Brave browser which I believe doesn't auto-update. Additionally it's much more familiar to people who use Ethereum dapps (aka most people in the crypto space). They are used to using Metamask and are rightfully very wary of putting private keys into a website.

Also from a user experience perspective keychain is so much easier. You never have to worry about where you saved your keys and copying/pasting them, especially if you have multiple accounts. You just type in the username you want and you're good to go.

$0.12

engrave (64) · 6 years ago

Thanks for the explanation - as I said, I will look into it definitely because it might be interesting :)

guchtere (65) · 6 years ago

Impressive guys very impressive😎👍

Posted using Partiko iOS

$0.02

chrisrice (59) · 6 years ago

I agree 😊

$0.10

engrave (64) · 6 years ago

Thank you :)

itegoarcanadei (60) · 6 years ago

Hello guys, congratulations for your excellent work! @engrave @wise-team
Just a couple of questions:

are you interested in an Italian (or Spanish, or both) tutorial to explain to these not english-spoken communities the ENGRAVE functions?
if so, would you be willing to support me?

Please let me know and keep up the good work!

Fabio

$0.00

engrave (64) · 6 years ago

Of course, we are interested in such tutorials as it can spread information across more potential bloggers :) We would love to see that and support as much as we can. Unfortunately, our SP amount is not so big, so we can't reward you with big upvote...

And we're going to introduce a brand new dashboard within weeks and it will change a lot of things, so maybe you should wait a bit with it?

$0.00

itegoarcanadei (60) · 6 years ago

Yes of course, I can wait, no prob. I did a tutorial for another steem dapp, you can find it on my blog if you want to have a look :) actually they are 2 posts, one for Italian and one for Spanish. Names are "Come giocare a Steem Slot Games" and "Como jugar con Steem Slot Games".

Posted using Partiko Android

$0.13

itegoarcanadei (60) · 6 years ago

Hello guys, how is going on your work? Better if I wait a little bit more in order to write the Engrave tutorial?
Sorry for bother you
Fabio

Posted using Partiko Android

$0.00

engrave (64) · 6 years ago

I think it's better to wait. I suppose it's not that far away.

$0.00

itegoarcanadei (60) · 6 years ago

Ok, just let me know when you are ready. I think engrave will be a great deal for these communities 😉 It's a really interesting project!

Posted using Partiko Android

$0.00

chrisrice (59) · 6 years ago

I found your post on the trending page @engrave and must say, so far I am impressed with your initial work on creating a blogging platform with Steem login's, upvotes and comments.

I'll be very happy if I start running acrossed blogs with Steem-based comments, etc. I upvoted this post 100% and I'll follow you to observe the progress the #wise-team makes.

$0.00

engrave (64) · 6 years ago

Thanks! You can find more blogs here: https://engrave.website/explore just take a look. Some of them might be empty but some of them are not :)

$0.00

noisy (67) · 6 years ago

That was in fact very important missing feature. This should boost number of interactions between Engravians (did I just invented a word? :D). It will be much more easily to add comments to different blogs :)

I guess, with cross-domain authentication, it would be very difficult to implement a history of visited engrave blogs, right? :)

engrave (64) · 6 years ago

I guess, with cross-domain authentication, it would be very difficult to implement a history of visited engrave blogs, right? :)

Every time you reach Engrave blog, you need to be remotely validated, so yes - it should be easy to add the history of visited blogs ;)

$0.00

arcange (73) · 6 years ago

Congratulations @engrave!
Your post was mentioned in the Steem Hit Parade in the following category:

Pending payout - Ranked 3 with $ 97,69

$0.00

alexs1320 (71) · 6 years ago

Wow, this is absolutely wonderful!

I'm so jealous when I see very successful blogs which are not related to Steem(it).

It would be perfect to seamlessly "infiltrate" in such communities.
For example https://tangosix.rs/ aviation ~~nuts~~ enthusiasts from Yugoslavia. 20M people who can possibly read that and 200 comments?! Even more on some texts.

It would be like a dream to call such communities to get on board.
In order to achieve that:

their favourite playground must stay the same (visually)
the process must be very simplified
My maybe crazy dream: the ability to post via "Guest Account"

Do you want to comment now? Good, you will post with "guest" posting key
And there should be a small checkbox, would you like to post as Steemian? Hm, what is Steem? It looks cool... I could do that...

Do you think it's possible/ viable?

Vote, ReSteem, Witness Vote ;)

$0.00

engrave (64) · 6 years ago

It would be perfect to seamlessly "infiltrate" in such communities

Would be great and I believe that Engrave is going in the direction which will allow us to do that.

My maybe crazy dream: the ability to post via "Guest Account"

I'm considering it from the very beginning and it will be introduced after some most necessary changes in a dashboard. Basically, the idea is to allow people to post comments without Steem account. Technically, it could be posted by blogger's account or @engrave account with additional pieces of information about a real author and blog (it could be rendered then as a guest account on blogs or something).

And we see a great opportunity here - it's possible to onboard most active commentators to Steem network - this comments could be used to "earn for an account" process. We could identify real authors by email and if this specific email earns more than 3 STEEM with their comments, we could create an account for him for free and send notification! And of course, those comments will be moderated to prevent spam or something :)

$0.00

alexs1320 (71) · 6 years ago

Yes! People are impulsive creatures. They want to say something Now, not in 2 hours or 2 weeks, but now.

Also, you know the rules of Pareto distribution, 1-10-90 % rules and so on. Most of the people will be just consumers. They want to read. 1/10 of them wants to Like, 1/10 of them wants to argue and 1/10 of them wants to actually write something.

Imagine a small town, 30,000 people. How many bloggers there will be? Well, maybe 30 at best, other people are living their daily boring lives. 2-3 photographers, 2-3 makeup beauty girls, 2-3 adventurers, doctors, tech enthusiasts - and that's it

Even those who write can't make more than 1 Steem/day on average, so why bothering at all to post comments for example via a private account. Who cares to hassle for 5$ per year or so.

Whish you good luck, if you need any help for "poking" people to join - call me :D

$0.14

Vote for Utopian Witness!

utopian-io (71) · 6 years ago

Hey, @engrave!

Thanks for contributing on Utopian.
Congratulations! Your contribution was Staff Picked to receive a maximum vote for the development category on Utopian for being of significant value to the project and the open source community.

We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

$0.00

pennsif (80) · 6 years ago

This post has been included in the latest edition of SoS Daily News - a digest of all you need to know about the State of Steem.

Editor of the The State of Steem SoS Daily News.
Promoter of The State of Steem SoS Weekly Forums.
Editor of the weekly listing of steem radio shows, podcasts & social broadcasts.
Founder of the A Dollar A Day charitable giving project.

$0.00

powerpens (41) · 6 years ago

Done voting @wise-team as Witness. (My first witness vote ever) 😀

Posted using Partiko Android

$0.00

felipejoys (71) · 6 years ago

Does ENGRAVE support Disqus? If not, can it support Disqus in the near future? Can you post a screenshot of the dashboard?

$0.00

engrave (64) · 6 years ago

Hi, we do not support Disqus because every blog is fully integrated with Steem. Your readers can log in on your blog using Steem account and interact with it. In the near future, we will introduce guests comments (people without Steem account will be able to comment on your articles) but it won't be a Disqus system,

$0.00

chrisrice (59) · 6 years ago

When I visit Emafe.com it isn't going to a splash page anymore @engrave, but is directed toward your homepage again. This is the problem I was experiencing before but I think you fixed it for a while.

Now it's back...

$0.00

nicniezgrublem (57) · 6 years ago

It should work fine and probably your browser just cached redirection. Try to force refresh it (use ctrl+f5)

yrali (21) · 6 years ago

me gusta la publicaciones

$0.00