Steem Monsters: SNAP! a casual picture taking game

stuffbyspencer (61) in steemmonsters • 7 years ago (edited)

View this post on Hive: Steem Monsters: SNAP! a casual picture taking game

7 years ago by stuffbyspencer (61)

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!

Sort Order:

Trending

[-]

amosbastian (72) · 7 years ago

Thanks for the contribution, @stuffbyspencer! It was a very interesting read for sure, and it's cool what you managed to implement in < 24 hours! Since you were obviously racing against the clock I won't be too nitpicky, but here's some things to keep an eye on:

Would be nice to have usage and installation instructions in the README.
Is there a reason why you don't have a space after the if/else in an if/else statement and have whitespace between brackets?

if( self.facing == 'NORTH' )
// Should be
if (self.facing == 'NORTH')

Commit messages could be a lot better (check this guide) and comments are basically non-existent.

Also, I was wondering if you are going to come back to your original idea and maybe flesh that out (instead of further developing like this like you mentioned at the end)?

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

$9.30

4 votes

[-]

stuffbyspencer (61) · 7 years ago

Hey, thanks for the helpful feedback!

To answer your questions:

I totally meant to have a more fleshed out README, completely slipped my mind. I'll update that shortly.
As for the spacing, honestly, it's just a personal preference. I don't know why, but I always felt more comfortable scanning through code when my if / else statements had spaces inside the brackets rather than in between the 'if' / 'else' and the bracket. Personal preference which I completely understand is probably annoying to some in the open-source space, my bad haha!
Thank you for the guide on commit messages. I rarely use git, so I had to learn about it a bit for this project. I'm excited to improve in the future. Comments in code will also be better when I have more time to develop the actual gameplay, mechanics, etc.

And, yes, I do plan on going back to my original idea at some point. I think this current game is very easy to touch up, so I'll probably still do that, but I'm hoping that if we get another Steem Monsters game jam in the future, I'll have enough time to bring my initial idea to life. Too much lore, ideas, and concepts to throw it away completely :)

Thanks again, take care! :D

$0.00

[-]

utopian-io (71) · 6 years ago

Thank you for your review, @amosbastian!

So far this week you've reviewed 1 contributions. Keep up the good work!

$0.00

[-]

utopian-io (71) · 7 years ago

Hey, @stuffbyspencer!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!