It's nice to revive project and not let them decay!
Let's hope it will be used :p
Let's go for the review:
Since the account doesn't have much Steems on it I'll write it: https://github.com/quochuy/pocketjs/commit/aefd1a49738bf72c926201b7da04e735ec25e42d#diff-e22b50e740e102c8de5e858dbcd7753dL6 => Never ever post your private keep! Github archives everything :p. You better change it now :D
https://github.com/quochuy/pocketjs/blob/master/bot/confirmer.js#L56 => Any particular reason for not using
&&
since you don't have anyelses
?https://github.com/quochuy/pocketjs/tree/master/bot/test => You have a lot of tests and there are not useless this is awesome !
https://github.com/quochuy/pocketjs/commit/92f21722b6b30d12fdff588407789f55cf3a1a66 => Try to do a better job about your commits ha ha,
can't remember... :-P
,misc
this is not serious, or havingValidator
orAdd config
twice. You can be more precise. Good comments are free!It's nice to add a docker config. Really cool.
This a great job overall!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
@gregory.latinier ARG! I thought I filtered out that from the history already! Thanks for letting me know!
And thanks for the very thorough review!
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
That was fast. Congrats @quochuy <3
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
To answer the other questions:
Thanks again @gregory.latinier
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit