RE: New Feature For SIDMM: Instruction Feature, Update feature on Report, and images slider on Home Page

You are viewing a single comment's thread from:

New Feature For SIDMM: Instruction Feature, Update feature on Report, and images slider on Home Page

in utopian-io •  5 years ago 

Thank you for your contribution!

  1. The code could be tidy-up a little bit by removing the commented-out code, extra lines, fixing the inconsistent code indention etc.
  2. The PHP code has been mixed with the UI presentation e.g. HTML, which could be fixed by choosing a proper template engine.
  3. the file naming is not consistent as well, some with Uppercase, some with dashes between.
  4. all changes are squeezed into one commit, which is not ideal, you may need to create a PR and put all your changes in it.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!
Sort Order:  

Thank you for your review, @justyy! Keep up the good work!