View this post on Hive: code review of changes since 0.20.5 - resource delegations pool objects were added
code review of changes since 0.20.5 - resource delegations pool objects were added
6 years ago by holger80 (72)
$49.36
- Past Payouts $49.36
- - Author $37.41
- - Curators $11.95
108 votes
- + reggaemuffin: $11.487 (100%)
- + ausbitbank: $9.939 (100%)
- + v4vapid: $8.458 (45%)
- + yabapmatt: $3.689 (100%)
- + inertia: $2.508 (100%)
- + stellabelle: $2.231 (100%)
- + steembasicincome: $1.487 (24%)
- + followbtcnews: $1.479 (100%)
- + snubbermike: $1.233 (100%)
- + aggroed: $1.070 (100%)
- + timcliff: $1.069 (100%)
- + therealwolf: $1.043 (100%)
- + partiko: $0.582 (100%)
- + teamsteem: $0.389 (5%)
- + themarkymark: $0.373 (5%)
- + taskmaster4450: $0.370 (50%)
- + mjhomb: $0.267 (100%)
- + deepdives: $0.257 (100%)
- + steem-ua: $0.245 (1.32%)
- + chbartist: $0.183 (100%)
- … and 88 more
Thanks for the summary!
Just a quick errata: resource budgets were actually decreased by a factor (partial reversion) but the other curve parameters were changed instead. According to their simulations, they expect the costs to go down though. Described in https://github.com/steemit/steem/issues/3061
Posted using Partiko Android
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Thanks! You are right and I corrected it in my code review.
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Thank you for reviewing the code!
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
wanna come on air roughly 25hrs from now for the Minnow Mayor Town Hall and walk through your findings?
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Thanks for the invitation, but this is middle of the night for me and I have to grasp some sleep :).
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Nice job!
Posted using Partiko Android
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Good job holger!
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Awesome, thanks Holger! Is beempy getting updated along with the new commits? I think I saw a new version yesterday when I was testing pywit.
Posted using Partiko Android
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Hi @holger80!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your UA account score is currently 6.996 which ranks you at #84 across all Steem accounts.
Your rank has improved 5 places in the last three days (old rank 89).
In our last Algorithmic Curation Round, consisting of 249 contributions, your post is ranked at #94.
Evaluation of your UA score:
Feel free to join our @steem-ua Discord server
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
im excited that rc delegation could be a thing soon. i find myself trying to find ways to get rid of my rc at the end of the night so it doesnt cap over night without having to create a random post or find a post worth commenting on when im busy. id much rather put my excess to good use for someone else.
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Woah. Massive changes, I have not seen an update saying we can delegate rc instead of sp yet is this what these changes mean? Will be so cool.
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Only the first point of the list has been implemented jet, it seems to be not finished by now.
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Ok thank you, I really hope they are making it a priority, rc delegation will boost interaction and since the vp is not tied it will be more difficult for people to still bleed the system since they can upvote themselves until blue in the face it won't help if they have no real power.
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Always good to to code review and cleanup of legacy code lines as without that it will become unreadable. One more thing I consider to be important is to break the code in multiple classes instead of having one class with thousand of code lines, so hopefully that doesn't happen here.
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Great
Posted using Partiko iOS
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit