Pull Request Submitted - Update Vote Slider Threshold to Include Delegated SP

in steemdev •  7 years ago 

After HF 19, a lot of users have been eagerly awaiting the use of the vote slider. Currently the vote slider appears when users have 1 MV of STEEM POWER (currently about 500 SP).

There is a problem with the vote slider though, in that it is not taking into account delegated SP. This causes a problem for new users who get delegated SP from other users, because even though they have enough SP to use the slider - the system doesn't recognize it. @roadscape opened GitHub Issue 1441 for this about a month ago.

I saw a post from @twinner a few days ago about how he tried to delegate SP to 125 German users so that they could use the slider, but then found out after the fact it didn't work! (post here)

I just submitted a pull request to correct the issue. If the pull request is accepted, it will take into account the delegated SP when determining whether or not to show the slider.

The pull request can be viewed here:
https://github.com/steemit/condenser/pull/1547

The PR is not accepted yet, but I plan to work with Steemit, Inc. to make any edits necessary to get it approved. Hopefully we will see the changes up on the live site soon!


Reminder to vote for witnesses!

The Steem witnesses are the elected leaders of the community that power the blockchain. Everybody should learn about the Steem witnesses and vote on who they think is best. If you don't know much about witnesses or aren't sure who to vote for, you can check out this Witness Voting Guide. If you think @timcliff is doing a great job, please consider voting for him as witness! You can vote for witnesses here: https://steemit.com/~witnesses

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!
Sort Order:  
You are Doing the Same what a Single User is Supposed to do in Open Source Community. Which makes Such Community Grow Faster, Error free & Reliable Because of the individual involvement. Thanks for your effort to present the issue in front of the community...
Thanks - @cWorldV99

valzav merged commit e1e1f43 into steemit:master a day ago

Great work Tim!! Must feel good when you see your efforts aren't in vain. :)

Yes, indeed. It is fun being on the website and coming across things where I get to think 'I did that' :)

LOL. Just as much fun for me when I see something on the website, and I know who did it too. hehe

lol... came here 4 days late to say the same :P

Good news, I am one of those 125 German delegates. Thanks for the post.

I love your avatar :)

This comment has received a 0.02 % upvote from @booster thanks to: @flauwy.

Well done post You deserve for getting Upvote from me. I appreciate on it and like it so much . Waiting for your latest post. Keep your good work and steeming on. Let's walk to my blog. I have a latest post. Your upvote is high motivation for me. Almost all Steemians do their best on this site. Keep steeming and earning.

This comment has received a 0.05 % upvote from @booster thanks to: @hamzaoui.

i appreciate all the hard work you do on our behalf @timcliff . upvoted and resteemed (i already voted for you as a witness- everybody else should too!)

Thanks :)

Oh so I have to thank you for this :).

I currently am lending 650 SP from @minnowbooster and suddenly yesterday I saw the slider when I tried to vote something.

Didn't know this was thanks to you.

I guess I have to thank you for the good job :)

Welcome :)

Tim, you're the man, thank you for giving me some info which helped me get back access to my steemit account.

You're welcome! I'm glad you were able to get back in :)

Thanks for info, I heard the vote slider appears around 438 SP from someone but I trust you on the 500 SP sounds about right. Slowly getting to 500 SP in time, thanks for update!

Well the exact amount (currently) is 483.385.

I really need this voting slider soon.

wow, this will be a game changer, thanks @timcliff . Steemit is great because of you @timcliff , also @twinner who delegated some steem power to lots of people including me and your team all working behind the scene for our common success. Bless you all. Danke Schön.

Thanks! I never even knew a slider existed!

Because minnows aren't allowed to have one apparently.

The blockchain does not allow votes below a certain amount. If minnows had a vote slider right away, and they tried to use it to cast low percentage votes - it would give them an error. Prior to HF 19, the vote slider appeared pretty much at the point that a minnow could use it to cast 1% votes without getting an error. After HF 19, it could be lowered to be 125. I submitted a PR for that a few weeks ago, but it is still in review.

That would be great, I hope that the PR is accepted! You are doing an excellent job for the community, thank you @timcliff!

Thanks :)

I see. I've got a lot more to learn about the steem blockchain

Hmm, interesting. Learn something new every day about Steemit.

Thank you for the update. I just hit 125 SP so I am eagerly hoping it gets accepted!

I always appreciate and value what you do for us and the platform, you dear friend @timcliff actively works on the platform, congratulations on the great performance
Have a beautiful weekend

Thanks @jlufer - you too :)

Thanks a lot @timcliff. This is very helpful. I was actually wondering about this concept but I could not find any information about it. I did a Google search with #Steemit as a keyword, but still didn't find anything, and here you have it all here. Great!

So the change would require about .25 MV correct or about 125 steem power? I think that is fair and allows more users to control where their power is going. Because 10 votes a day isnt much if you use SteemIt as much as most of us do.

The change to 0.25 is unrelated to this one. I submitted a separate PR for that a little over a week ago. That one is still in review. https://github.com/steemit/condenser/pull/1511

This most recent change fixes it so that it takes delegated SP into account. Whatever the threshold is (500 or 125) it will look at the total amount of SP a user has, which includes what was delegated to them.

  ·  7 years ago (edited)

Yeah i understand this new change, and it makes sense for sure. Thanks for working on these changes for the minnows.

tbh... your previous pull request on the vote slider becoming available with ~125SP seems much more relevant and you should have given it a mention here...

still, great work... steem-on!

yeah I know... I've been sharing it all over the place ;)

what I meant is that it could have also been mentioned in this post, as many will come here not knowing that there's an even better improvement that you proposed!

either way, great work!

Thanks for posting, hopefully one day I will get a vote slider!

I am not sure about your background but from what I've read so far you start to became a real C programmer in the last month :) - Keep up your great work @timcliff!

Thanks. My very early background is in C/C++, but it has been a while since I've done programming in that language. I've mostly been doing C# for work for the past several years. The condenser (Steemit.com) code uses react.js and node.js - which is very similar to JavaScript. I've been learning it as I go :)

@timcliff Thanks for staying in front of those things. As those abilities are unlocked, it is frustrating when the functionality doesn't work as advertised. Kudos for the excellent work.

Witness Voting 06 timcliff //// Brother you deserve more than that ////
We hope some users get (delegated steem power)

Not sure how this going to play out but I'm interested to see it come to reality.

great to see this has been deployed! kudos!

thanks @timcliff,

I think this is important, I just make the program adjusting voting power for new users, but browser's localStorage is not affect to new user. It's good functions.

Thanks @timcliff. Hope it gets accepted. I need this to actually take one of my posts idea ahead.

Also because like you mentioned, it doesn't make sense for delegated SP not count when voting using the slider. Shout a new post for everyone to know if his gets accepted.

I typically don't post a second time when the pull requests are accepted (or rejected). If you are interested in tracking the progress, you can monitor it here. Usually Steemit reviews them within a couple of weeks, often sooner.
https://github.com/steemit/condenser/pull/1547

Hi @timcliff i guess you might be right person to ask. I sent reply to comment and it is blank right now (but it was not). Here is direct link https://steemdb.com/tag/@whd/re-aksinya-travel-contest-7-guess-the-location-easy-to-participate-20170701t131010112z
steamdb says block has been Witnessed by you https://steemdb.com/block/13333903
Could you tell me what happend?:)

Your comment was "San francisco", correct?

I see it there on the blockchain:
https://steemd.com/tag/@whd/re-aksinya-travel-contest-7-guess-the-location-easy-to-participate-20170701t131010112z

It also looks like it is showing up on steemdb now:
https://steemdb.com/tag/@whd/re-aksinya-travel-contest-7-guess-the-location-easy-to-participate-20170701t131010112z

It was probably a temporary glitch displaying the data on steemd.com. If you still see an issue let me know.

I have informed my local witness, and he forwarded case to the developers so i guess we can say it is closed issue. Thanks for the reply!

Thanks for staying @timclif