My First Steemit Pull Request

in steemit •  7 years ago 

I'm not a "real" developer. More of a savvy user or enthusiast. So I'm pretty pleased with myself after having my first pull request accepted for Steemit's condenser platform.

For those who don't know, the codebase for steemit.com is open source and available on github. Anybody with the skill and desire to do so can contribute to the web site. I have a few ideas for improvements to the site that seem simple enough, so I've looked around the source a bit. I wasn't able to figure out how to implement my ideas, but I recently came across a problem that put well meaning users at risk of losing SBD.

By now a lot of us have heard about @randowhale. He's a new whale account set up specifically to let users spend 2 SBD to get a random vote, which may end up increasing their earnings above the 2 SBD they spent. Cool idea, right?!

Well... Apparently somebody decided that it would be a good opportunity to take advantage of people, and essentially steal money from people for making a simple mistake....

Serial small time scammer and troll @noganoo registered the name @randomwhale in order to steal from the honest members of our community. By the time I learned about it, he had already taken 10 SBD from users who made a simple mistake. (which would not have been possible until he created his scam account... the blockchain won't let you send tokens to accounts which don't exist!)

From poking around before, I knew where to find the list of "bad actors" that the wallet warns you about during transfers.

I knew that by adding @randomwhale to the list, it might help users avoid the scam that others had already fallen victim to. It was a little thing, but it could help. So I decided to give it a shot. And with the help of @lukestokes, who walked me through the process of forking the repository, committing my changes, and finally submitting the pull request... I did it!

After a bit of time, I got a notification that it had been reviewed. @sneak accepted it and merged it! Soon, when a user accidentally fills in "randomwhale", they will get a notice to check the name they are sending to.

I'm remarkably proud for having done so little! :D

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!
Sort Order:  

That's awesome! Takes balls to tackle something for the first time!

fist-pump-baby-you-did-it-.jpg

This post received a 7% upvote from @randowhale thanks to @bacchist! For more information, click here!

thank you. I recently made a post praising randowhale for making steemit even more fun. someone commented and wrote how much they loved @randomwhale. they commented the wrong name on my post and it had to be cleared up! hope what you did helps!

Grats on your first pull request! Great change to check in. Thanks for doing this :)

Congrats man! I plan to start learning C++ tomorrow, I want to be a dev for a living!

You can do literally anything you want. You're ahead of the curve. It's up to you. ;)

No @randomwhale but @randowhale

How is it that this guy still has a 64 reputation with all those posts hidden due to low ratings?

lgtm, ship it

The world needs more guys like you. Watching out for the community.

Holy crap man, that is awesome! Same boat as you, savvy user....just enough to get ourselves int some trouble, but you did indeed go down the rabbit whole to make this option available. Good stuff!

Good move and congrats!

Great job man! Every little improvement helps a ton!

Thx bacchist!

We do need a system to remind Steemian who are bad.
Really nice idea !
Resteemed! Let's more ppl know your idea.

thanks for the post, it's a good warning...I would hate to waste 2 sbd for nothing...upvoted and followed.

@bacchist In fairness, noganoo did get back to me stating that he would be implementing a similar system as randOwhale, The last I checked he did up vote those who had mistakenly sent money to his acct ... i am hoping that this remains the case.

With his track record, I can't give him any credit for having good intentions.

well at least I now know who to go to in case I run into something like this again. I was one of the first ones to make that mistake. Thanks and way to go @bacchist

Congratulations @bacchist! You have completed some achievement on Steemit and have been rewarded with new badge(s) :

Award for the number of upvotes

Click on any badge to view your own Board of Honnor on SteemitBoard.
For more information about SteemitBoard, click here

If you no longer want to receive notifications, reply to this comment with the word STOP

By upvoting this notification, you can help all Steemit users. Learn how here!

Congratulations @bacchist! You have completed some achievement on Steemit and have been rewarded with new badge(s) :

Award for the total payout received

Click on any badge to view your own Board of Honnor on SteemitBoard.
For more information about SteemitBoard, click here

If you no longer want to receive notifications, reply to this comment with the word STOP

By upvoting this notification, you can help all Steemit users. Learn how here!

Great, that you react and make it public. Good to know. I want to use Randowhale next time. So I have reminder now for the right thing.