QKSMS 3.1.3 Crash with enable/disable nigth mode

Project Information

• Repository: https://github.com/moezbhatti/qksms
• Project Name: Qksms
• Publisher: Moez Bhatti

Expected behavior

At the moment of activating night mode, the software shouldn't crash and changed successfully the colours.

If the device default language is "English" works properly, but another language just crash.

Actual behavior

Enabling or disabling the night mode produces a crash on the app. After this, opening the app will start with the mode that was selected.

How to reproduce

1. Install the application.
2. Open it.
3. Go to settings.
4. Enable/disable night mode (Always on/disabled)

• Device: Alcatel Fierce 4 5056N
• Operating system: Android 6.0.1 Marshmallow
• App version: 3.1.3
• Device Language: Spanish

Logcat

--------- beginning of crash

05-20 03:48:08.803 22516 22516 E AndroidRuntime: FATAL EXCEPTION: main
05-20 03:48:08.803 22516 22516 E AndroidRuntime: Process: com.moez.QKSMS, PID: 22516
05-20 03:48:08.803 22516 22516 E AndroidRuntime: io.reactivex.exceptions.OnErrorNotImplementedException: Unparseable date: "6:00 AM" (at offset 5)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:704)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.internal.functions.Functions$OnErrorMissingConsumer.accept(Functions.java:701)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.internal.observers.LambdaObserver.onError(LambdaObserver.java:77)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at com.uber.autodispose.HalfSerializer.onError(HalfSerializer.java:159)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at com.uber.autodispose.AutoDisposingObserverImpl.onError(AutoDisposingObserverImpl.java:91)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.observers.SerializedObserver.onError(SerializedObserver.java:155)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.internal.operators.observable.ObservableWithLatestFrom$WithLatestFromObserver.onNext(ObservableWithLatestFrom.java:79)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.subjects.PublishSubject$PublishDisposable.onNext(PublishSubject.java:264)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.subjects.PublishSubject.onNext(PublishSubject.java:183)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at common.MenuItemAdapter$onBindViewHolder$1.accept(MenuItemAdapter.kt:87)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at common.MenuItemAdapter$onBindViewHolder$1.accept(MenuItemAdapter.kt:43)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.internal.operators.observable.ObservableMap$MapObserver.onNext(ObservableMap.java:64)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at com.jakewharton.rxbinding2.view.ViewClickObservable$Listener.onClick(ViewClickObservable.java:39)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at android.view.View.performClick(View.java:5205)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at android.view.View$PerformClick.run(View.java:21164)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at android.os.Handler.handleCallback(Handler.java:739)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at android.os.Handler.dispatchMessage(Handler.java:95)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at android.os.Looper.loop(Looper.java:148)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at android.app.ActivityThread.main(ActivityThread.java:5417)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at java.lang.reflect.Method.invoke(Native Method)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
5-20 03:48:08.803 22516 22516 E AndroidRuntime:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
05-20 03:48:08.803 22516 22516 E AndroidRuntime: Caused by: java.text.ParseException: Unparseable date: "6:00 AM" (at offset 5)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at java.text.DateFormat.parse(DateFormat.java:579)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at          common.util.DateFormatter.parseTime(DateFormatter.kt:85)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at common.util.NightModeManager.createCalendar(NightModeManager.kt:85)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at common.util.NightModeManager.updateAlarms(NightModeManager.kt:63)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at common.util.NightModeManager.updateNightMode(NightModeManager.kt:59)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at feature.settings.SettingsViewModel$bindView$$inlined$withLatestFrom$1.apply(Observables.kt:195)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    at io.reactivex.internal.operators.observable.ObservableWithLatestFrom$WithLatestFromObserver.onNext(ObservableWithLatestFrom.java:75)
05-20 03:48:08.803 22516 22516 E AndroidRuntime:    ... 16 more

Recording Of The Bug

Spanish

Korean

English (Works properly)

GitHub Account

Josemape