Major bug fixes in Susi Desktop

in utopian-io •  7 years ago  (edited)

Bug Fixes

What was the issue(s)?

  • The electron version used in the app was old and had critical security issues. Which was stated by me in this issue made - #105

  • Clicking the link in the app didnt open the link in new window or browser. This was highlighted by me in this issue - #106

  • The package manager must be updated to yarn as yarn is cooler than npm. It was stated in this issue - #107

  • The travis and codacy had conflicts in thier checks which made one of them fail always whiihc was stated in the issue here - #109.

What was the solution?

  • For opening the link in another window there were two options node-open package or open-external. I worked it out with open external as it is inbuilt in electron library.
    Following code segment was used for it -
webview.addEventListener('new-window', e => {
        const protocol = require('url').parse(e.url).protocol;
        if (protocol === 'http:' || protocol === 'https:') {
            shell.openExternal(e.url);
        }
    });
  • Electron update was done with the correct commad.
  • npm was replaced with yarn
  • For codacy to be configured i alignment with Travis I added .eslintrc.js. This added config for Codacy to perform checks in a PR.

Technology Stack

  • Electron JS.

How to contribute?

Feel free to fork and contribute to codebase.
Click here to go to the repository.



Posted on Utopian.io - Rewarding Open Source Contributors

Authors get paid when people like you upvote their post.
If you enjoyed what you read here, create your account today and start earning FREE STEEM!
Sort Order:  

Thank you for the contribution. It has been approved.

You can contact us on Discord.
[utopian-moderator]

Hey @sachincool, I just gave you a tip for your hard work on moderation. Upvote this comment to support the utopian moderators and increase your future rewards!

Upvoted ☝ Have a great day!

1UP-Kayrex_tiny.png

You've got upvoted by Utopian-1UP!

You can give up to ten 1UP's to Utopian posts every day after they are accepted by a Utopian moderator and before they are upvoted by the official @utopian-io account. Install the @steem-plus browser extension to use 1UP. By following the 1UP-trail using SteemAuto you support great Utopian authors and earn high curation rewards at the same time.


1UP is neither organized nor endorsed by Utopian.io!

Hey @ms10398 I am @utopian-io. I have just upvoted you!

Achievements

  • WOW WOW WOW People loved what you did here. GREAT JOB!
  • You have less than 500 followers. Just gave you a gift to help you succeed!
  • Seems like you contribute quite often. AMAZING!

Community-Driven Witness!

I am the first and only Steem Community-Driven Witness. Participate on Discord. Lets GROW TOGETHER!

mooncryption-utopian-witness-gif

Up-vote this comment to grow my power and help Open Source contributions like this one. Want to chat? Join me on Discord https://discord.gg/Pc8HG9x