[Steemwatch] Do Not Send Notifications Related to Muted Users
Issue
Currently when you mute a user on the blockchain, Steemwatch will still send alerts about their comments on your posts (if you have that feature turned on).
Recommendation
Please do not send notifications to a user if the generating user has been muted. For instance, if Bob mutes Alice on the blockchain and Alice comments on Bob's post, Bob will receive a Steemwatch alert for Alice's comment. What should happen in reality is that Bob is not notified via any of the methods Steemwatch is configured for.
Pseudo-code
// CommentPublished
func renderCommentPublishedEvent(event *events.CommentPublished) string {
c := event.Content
// return if user is muted by account
commentLines := make([]string, 0, 5)
scanner := bufio.NewScanner(strings.NewReader(c.Body))
for scanner.Scan() {
commentLines = append(commentLines, scanner.Text())
}
extractLines := commentLines
if len(extractLines) > 5 {
extractLines = extractLines[:5]
}
extract := strings.Join(extractLines, "\n")
if len(commentLines) > 5 {
extract += fmt.Sprintf("\n<https://steemit.com%v|Read more...>", c.URL)
}
return fmt.Sprintf(`
**-----**
%v commented on @%v/%v.
**Content:** %v
`,
steemitLink(c.Author),
c.URL,
c.ParentAuthor,
c.ParentPermlink,
extract,
)
}
Links
Open Source Contribution posted via Utopian.io
Hey @netuoso I am @utopian-io. I have just super-voted you at 1.6% Power!
Suggestions https://utopian.io/rules
Achievements
Up-vote this comment to grow my power and help Open Source contributions like this one. Want to chat? Join me on Discord https://discord.gg/Pc8HG9x
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
My biggest concern we have right now is that we have zero way to completely block another user if we choose to, for example Bob blocks Alice and Alice feels it's a perfectly proper reason to send messages via transfer comments to directly harass Bob after being asked not to and subsequently muted. I foresee that causing issues in the future beyond the fact that it already annoys the piss out of me to get those solicitation messages. Shrug ... Any thoughts on how to address that?
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Probably just hide any data sent from a muted user for the person logged into the frontend. Just cause you don't like seeing it, it still has to be on the chain.
So it would be the duty of the frontend to hide it I believe.
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
My thoughts are that if we are capable of encrypting and hiding messages so that it's not public knowledge... couldn't we just do that by default for all messages?
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Not sure how encrypted messages would solve the muting issue ?
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Well I agree that the issue you are originally referring to in the post is pretty much going to have to be a front end fix, but the transfer messages could be an account level setting couldn't they? Like submit a pull request to make all messages encrypted and require active key sign in or perhaps have the ability as an account setting that can be manually disabled on a per account basis? I'm not trying to hijack the topic, I just think they are similar issues in the sense that they both relate to undesirable messages being received.
edit I guess it could cause further complications with exchanges though... maybe that wouldn't be such a simple fix.
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Eres muy guapo ;)
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Yes right sir
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit
Thank you for the contribution. It has been approved.
You can contact us on Discord.
[utopian-moderator]
Downvoting a post can decrease pending rewards and make it less visible. Common reasons:
Submit